> >>
> >> +static int is_route_inactive_port0(Node * node, Port * port, Switch
> >> +*
> >> +sw) {
> >
> > I would prefer this function be named something like:
> >
> > port_inactive_not_bsp0
> >
> > The current name is confusing as to what the logic is.
>
> How about is_port_inactive ?
That is fine.
>
> >> + int res = 0;
> >> + /* not active for HCA and for enhanced port0 Switches */
> >> + if (port->state != 4 &&
> >
> > Please use #defines here even though the original code did not.
>
> This is an issue throughout infiniband-diags. I think it should be addressed
> by
> separate patch(es) for this.
I would rather see us do the right thing going forward. This saves work trying
to find all these majic numbers later.
Ira
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
