Le dimanche 01 février 2015 à 15:35 +0200, Haggai Eran a écrit :
> Commit 5a77abf9a97a ("IB/core: Add support for extended query device caps")
> added a new extended verb to query the capabilities of RDMA devices, but the
> semantics of this verb are still under debate [1].
> 
> Block access to this verb from user-space until the new semantics are in
> place.
> 
> Cc: Yann Droneaud <[email protected]>
> Cc: Jason Gunthorpe <[email protected]>
> Cc: Eli Cohen <[email protected]>
> 
> [1] [PATCH v1 0/5] IB/core: extended query device caps cleanup for v3.19
>     http://www.spinics.net/lists/linux-rdma/msg22904.html
> 
> Signed-off-by: Haggai Eran <[email protected]>

Reviewed-by: Yann Droneaud <[email protected]>

> ---
> 
> Hi Roland,
> 
> As I wrote in a separate mail, I hope you can accept Yann's patches to modify
> the new query device verb [1] in time for kernel 3.19. 
> 
> If you decide to revert the extended query device verb, here is a minimal 
> patch
> to do block this verb temporarily, leaving the rest of the ODP infrastructure
> in-place.
> 
> Regards,
> Haggai
> 
>  drivers/infiniband/core/uverbs_main.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/infiniband/core/uverbs_main.c 
> b/drivers/infiniband/core/uverbs_main.c
> index e6c23b9eab33..5db1a8cc388d 100644
> --- a/drivers/infiniband/core/uverbs_main.c
> +++ b/drivers/infiniband/core/uverbs_main.c
> @@ -123,7 +123,6 @@ static int (*uverbs_ex_cmd_table[])(struct ib_uverbs_file 
> *file,
>                                   struct ib_udata *uhw) = {
>       [IB_USER_VERBS_EX_CMD_CREATE_FLOW]      = ib_uverbs_ex_create_flow,
>       [IB_USER_VERBS_EX_CMD_DESTROY_FLOW]     = ib_uverbs_ex_destroy_flow,
> -     [IB_USER_VERBS_EX_CMD_QUERY_DEVICE]     = ib_uverbs_ex_query_device
>  };
>  
>  static void ib_uverbs_add_one(struct ib_device *device);

That's the smallest (and smartest) patch to be applied instead of
reverting.

Regards.

-- 
Yann Droneaud
OPTEYA


--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to