From: Ira Weiny <[email protected]>
Fix the following issues reported by Dan:
1. I found an issue with the /etc/init.d/rdma-ndd script. The âstopâ option
(e.g. /etc/init.d/rdma-ndd stop) doesnât kill the rdma-ndd. The problem is
that the rdma-ndd doesnât creates pidfile. Just like opensm the rdma-ndd
should create/remove pidfile in /var/run/rdma-ndd.pid The pidfile is being
used by âkillprocâ that is being called from stop() function in .
/etc/init.d/rdma-ndd script. So, I think that just like opensm the rdma-ndd
should have an option for â--pidfileâ
2. Regardless, the /etc/init.d/rdma-ndd script is missing the following lines
(please see this git diff):
diff --git a/etc/rdma-ndd.init.in b/etc/rdma-ndd.init.in
index 41747f2..3605f5a 100644
--- a/etc/rdma-ndd.init.in
+++ b/etc/rdma-ndd.init.in
@@ -40,7 +40,8 @@
# Redistributions in binary form must reproduce both the
# above copyright
# notice, one of the license notices in the documentation
# and/or other materials provided with the distribution.
-
+prefix=@prefix@
+exec_prefix=@exec_prefix@
pidfile=/var/run/rdma-ndd.pid
This fix will direct the path for sbindir to be /usr/sbin/ (as sbindir by
default will be (from configure --help) â--sbindir=DIR system admin
executables [EPREFIX/sbin]â) and the rdma-ndd to be taken from
/usr/sbin/rdma-ndd. When I checked it in Debian OS the /etc/init.d/rdma-ndd
script tried to find the rdma-ndd in /sbin/rdma-ndd and gave me an error. So
this fix this problem.
Dan Ben Yosef
Ira Weiny (2):
infiniband-diags/rdma-ndd: Fix issues with install
infiniband-diags/rdma-ndd: add --pidfile option
Makefile.am | 3 +++
doc/man/rdma-ndd.8.in | 3 +++
doc/rst/rdma-ndd.8.in.rst | 3 +++
etc/rdma-ndd.init.in | 6 ++++--
src/rdma-ndd.c | 35 +++++++++++++++++++++++++++++++++--
5 files changed, 46 insertions(+), 4 deletions(-)
--
1.8.2
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
