> > The IBA is pretty clear what should happen to process an unsupported > class > > version and and adding OPA shouldn't suddenly make the IB side > > non-conformant, however aesthetically unpleasing the code may be. > > Are there checks to ensure that MADs not supported by RoCE aren't > processed on RoCE ports?
For the receive side, we need to enhance the validate_mad(). A similar check could be added to the send side, if we don't trust the senders. Mgmt_class checks are everywhere in the code. Pairing each with device checks for IB, RoCE, or OPA would be unwieldy. IMO, a MAD should be self-identifying. E.g. update the mad private structure to indicate what sort of MAD it is -- is_smp(), is_gmp(), is_rmpp(), is_opa(), is_ib(), much like the device checks are being updated. -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
