On Tue, Apr 14, 2015 at 11:52:11AM +0300, Sagi Grimberg wrote: > On 2/23/2015 6:50 AM, Yuval Shaia wrote: > >Current approach force one to implement all ops even when some functions can > >use the default implementation. > >As a result, for new DMA ops (e.x new arch) many functions just wrap the > >default function. > >The fix is to check each DMA operation individually so one can leave empty > >the ones not need to be override. > > > > I guess this is OK, but aren't we better off with wrappers than > adding another condition statement?
Yeah, the drivers should provide all the ops. With the current scheme the core could fill in the NULL ops with default on device register, other subsystems do this. Jason -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
