Hi,

The patch is broken - you did not update 


> -----Original Message-----
> From: [email protected] [mailto:linux-rdma-
> [email protected]] On Behalf Of David Ahern
> Sent: Saturday, May 02, 2015 12:22 AM

<snipped>

> 
>  static int cm_compare_data(struct ib_cm_compare_data *src_data,
>                          struct ib_cm_compare_data *dst_data)
>  {
> -     u8 src[IB_CM_COMPARE_SIZE];
> -     u8 dst[IB_CM_COMPARE_SIZE];
> +     u32 src[IB_CM_COMPARE_SIZE];
> +     u32 dst[IB_CM_COMPARE_SIZE];
> 
>       if (!src_data || !dst_data)
>               return 0;
> @@ -460,10 +459,10 @@ static int cm_compare_data(struct
> ib_cm_compare_data *src_data,
>       return memcmp(src, dst, IB_CM_COMPARE_SIZE);

You added a BUG here - you should use (IB_CM_COMPARE_SIZE * sizeof(u32)).
Same bug is also appearing at 
http://lxr.free-electrons.com/source/drivers/infiniband/core/cm.c#L472
http://lxr.free-electrons.com/source/drivers/infiniband/core/cm.c#L956

It might be better to keep IB_CM_COMPARE_SIZE to the original value, and
divide by sizeof(u32) in the uses which iterate over a 32-bit data type.


Thanks,
--Shachar
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to