Here Sean reacts to our RoCEv2 patches (same thread as the one I sent before with Jason's feedback). Sean is not even making technical statements to dismiss our patches. He has been rejecting all our previous revs of this set with loose FUD comments. In this case he chose to count the lines of code.
> -----Original Message----- > From: [email protected] [mailto:linux-rdma- > [email protected]] On Behalf Of Hefty, Sean > Sent: Wednesday, June 10, 2015 12:10 PM > To: Or Gerlitz; Doug Ledford; Jason Gunthorpe > Cc: Matan Barak; Moni Shoua; Somnath Kotur; [email protected] > Subject: RE: [PATCH for-next V5 00/12] Move RoCE GID management to > IB/Core > > > Sean, this change is needed b/c two drivers have (mlx4 and ocrda) and > > more two to come soon (mlx5 and soft-Roce) would have the very same > > logic of constructing the port GID table according to netdev events > > and such, no point in repeating this logic/code over and over. > > > > Matan explained why we don't have 2 x Y deletions and 1 x Y insertions. > > It more than doubles the amount of code. That's not a cleanup. It introduces > a bunch of new functionality. Jason has asked repeatedly to remove the > RoCEv2 code, and that has been ignored repeatedly. As far as I'm concerned, > this patch is not worth my time, and I will no longer even bother following > this series. > -- > To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the > body of a message to [email protected] More majordomo info at > http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
