On Wed, Jun 10, 2015 at 08:15:56PM -0400, Doug Ledford wrote: > I'm not sure the complexity here is "latent RoCEv2" stuff versus simple > over-design.
Well, for instance, the wrong RCU locking around table->data_vec[ix].attr.ndev appears to exist to support find_gid when called with GID_ATTR_FIND_MASK_NETDEV outside callers that hold table->lock. However, the unlocked call pattern is never used with GID_ATTR_FIND_MASK_NETDEV - that possibility was punted in v5, but the code to support it and the broken RCU to help it are still present, and will eventually be needed by rocev2 and roce namespaces.. That is just one small example, I fully expect there are others, and I think your remark about 'over-design' is likely equally contributing to the size expansion as well. Jason -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
