On 06/10/2015 06:15 PM, Weiny, Ira wrote: >>>> Registering an event handler is done for a device. This device may >>>> have one RoCE port (no SA cap) and one InfiniBand port (has SA cap). >>>> Therefore, warning from the event handler about a specific port that >>>> doesn't have SA cap is correct but pollutes the kernel log without a >>>> need. >>> >>> Maybe we should think about register event handler per port :-P >> >> I agree, though I think that can be added separately from this change. > > Also agreed. We identified many places where we should split support to be > per port while we did this work. We need to start working up to that. For > the time being we should not break existing users (or in this case annoy > them... ;-)
IMHO we can do some reform inside ib_dispatch_event(), where we already have the port number related to the event, if we could have an event_handler_list per port and classified the callback inside ib_register_event_handler(), then we can call the handler on the right port meanwhile won't annoy the user ;-) Regards, Michael Wang > > Ira > -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
