On Sun, Jun 14, 2015 at 11:58:00PM +0300, Or Gerlitz wrote: > On Fri, Jun 12, 2015 at 2:09 AM, Mike Marciniszyn > <[email protected]> wrote: > > +++ b/drivers/infiniband/hw/hfi1/device.c > > > +int __init dev_init(void) > > +{ > > + int ret; > > + > > + ret = alloc_chrdev_region(&hfi1_dev, 0, HFI1_NMINORS, DRIVER_NAME); > > + if (ret < 0) { > > + pr_err("Could not allocate chrdev region (err %d)\n", -ret); > > + goto done; > > + } > > + > > + class = class_create(THIS_MODULE, class_name()); > > + if (IS_ERR(class)) { > > + ret = PTR_ERR(class); > > + pr_err("Could not create device class (err %d)\n", -ret); > > + unregister_chrdev_region(hfi1_dev, HFI1_NMINORS); > > + } > > + > > +done: > > + return ret; > > +} > > so what's the role of the char-device? why should a low-level driver > which is part of the upstream RDMA stack contain a char-device?
I for one would like to see a summary of any non-standard UAPI from this driver. Was Al Viro's comment on qib addressed here? That would be a showstopper for me.. Jason -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
