> > > > Please accept my apologies. The original patch used WARN_ON but I was > advised to use BUG_ON in a review and I should have thought about it more > rather than blindly make the change. > > > Ira, > > Can you please point me to the review thread where this advise was made? I > can't track it. In internal reviews I always fight with developers that put > BUG_ON assertions whenever something goes wrong, I'd like to see on what > context this feedback was provided to you.
This was recommended for 2 patches but I did not change the first. http://www.spinics.net/lists/linux-rdma/msg25514.html This is an earlier version of the patch Linus objected to http://www.spinics.net/lists/linux-rdma/msg25498.html Ira
