> From: Jason Gunthorpe [mailto:[email protected]] > Sent: Tuesday, June 30, 2015 6:25 PM > To: Wan, Kaike > Cc: [email protected]; Fleck, John; Weiny, Ira > Subject: Re: [PATCH v7 4/4] IB/sa: Route SA pathrecord query through netlink > > On Tue, Jun 30, 2015 at 09:45:55AM -0400, [email protected] wrote: > > > +static inline int ib_nl_is_good_resolve_resp(const struct nlmsghdr > > +*nlh) { > > + const struct nlattr *head, *curr; > > + int len, rem; > > + > > + if (nlh->nlmsg_flags & RDMA_NL_LS_F_ERR) > > + return 0; > > + > > + if (!(nlh->nlmsg_flags & RDMA_NL_LS_F_OK)) > > + return 0; > > + > > + if (nlmsg_len(nlh) < nla_attr_size(sizeof(*rec))) > > + return 0; > > Um, why are you sending patches that are not even compile tested?
My bad. I had a debugging patch on top of these patches and I built them together to do the tests (rdma_cm, ipoib, srp), but forgot to compile the rest after popping off the debugging patch. > > drivers/infiniband/core/sa_query.c: In function 'ib_nl_is_good_resolve_resp': > drivers/infiniband/core/sa_query.c:732:45: error: 'rec' undeclared (first use > in this function) > if (nlmsg_len(nlh) < nla_attr_size(sizeof(*rec))) > > This routine should also be using nla_parse and friends, not a roll your own. Yes, I can use nla_find() for this purpose here. > > And you didn't address all the comments either.. I addressed your comments with questions in an previous reply, but did not hear from you. See http://www.mail-archive.com/[email protected]/msg25614.html Thanks, Kaike > > Jason -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
