On 07/24/2015 10:50 AM, Steve Wise wrote: > > >> -----Original Message----- >> From: [email protected] >> [mailto:[email protected]] On Behalf Of Doug Ledford >> Sent: Friday, July 24, 2015 9:45 AM >> To: Steve Wise >> Cc: [email protected] >> Subject: Re: [PATCH] RDMA/cxgb3: fail get_dma_mr if the memory footprint can >> exceed 32b >> >> On 07/23/2015 06:47 PM, Steve Wise wrote: >>>> -----Original Message----- From: Doug Ledford >>>> Should this be a static check of the pointer size versus installed >>>> memory? Would it be possible to have this work for machines with >>>> less than 4GB of physical memory even if they have 64bit pointers, >>>> or are you concerned that hotplug memory could take us over the >>>> limit after registration and cause problems? >>> >>> NFSRDMA doesn't need dma-mrs for T3 since it has FRMR + local dma >>> lkey support. And since the deficiency really can cause problems on >>> 64b systems if the memory grows > 4GB after dma-mr allocation, I >>> decided to just not allow them for potential large memory systems. >> >> Ok. I've pulled this for 4.2-rc then. >> > > The problem has been there since day one, so it doesn't represent a > regression. It is your call, but I think 4.3 is fine.
It's a long standing problem, but it's a potential memory wrap issue, so might as well fix it (especially given the simple nature of the fix). I've got a few other things heading in for 4.2-rc, so no biggie. -- Doug Ledford <[email protected]> GPG KeyID: 0E572FDD
signature.asc
Description: OpenPGP digital signature
