On 07/28/2015 10:13 AM, Steve Wise wrote:
> Currently the sg tablesize, which dictates fast register page list
> depth to use, does not take into account the limits of the rdma device.
> So adjust it once we discover the device fastreg max depth limit.  Also
> adjust the max_sectors based on the resulting sg tablesize.
> 
> Signed-off-by: Steve Wise <[email protected]>
> ---
> Note: This patch was originally part of
> http://www.spinics.net/lists/linux-rdma/msg27436.html. The isert work
> will be a separate series, so I'm submitting this one to go ahead and
> get it merged.
> ---
> 
> 
>  drivers/infiniband/ulp/iser/iscsi_iser.c |    9 +++++++++
>  1 files changed, 9 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/infiniband/ulp/iser/iscsi_iser.c 
> b/drivers/infiniband/ulp/iser/iscsi_iser.c
> index 6a594aa..de8730d 100644
> --- a/drivers/infiniband/ulp/iser/iscsi_iser.c
> +++ b/drivers/infiniband/ulp/iser/iscsi_iser.c
> @@ -640,6 +640,15 @@ iscsi_iser_session_create(struct iscsi_endpoint *ep,
>                                                  SHOST_DIX_GUARD_CRC);
>               }
>  
> +             /*
> +              * Limit the sg_tablesize and max_sectors based on the device
> +              * max fastreg page list length.
> +              */
> +             shost->sg_tablesize = min_t(unsigned short, shost->sg_tablesize,
> +                     ib_conn->device->dev_attr.max_fast_reg_page_list_len);
> +             shost->max_sectors = min_t(unsigned int,
> +                     1024, (shost->sg_tablesize * PAGE_SIZE) >> 9);
> +
>               if (iscsi_host_add(shost,
>                                  ib_conn->device->ib_device->dma_device)) {
>                       mutex_unlock(&iser_conn->state_mutex);
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to [email protected]
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

Thanks Steve, I'm picking this one up today.

-- 
Doug Ledford <[email protected]>
              GPG KeyID: 0E572FDD


Attachment: signature.asc
Description: OpenPGP digital signature

Reply via email to