On Thu, Aug 6, 2015 at 2:23 AM, Hefty, Sean <[email protected]> wrote: >> I don't think we should over-complex things vs. what the network stack >> does for many (since kernel 2.4?!) years. They have basically three >> flags >> >> NETIF_F_IP_CSUM - device can checksum TCP/UDP over IPv4 >> NETIF_F_IP6_CSUM - device can checksum TCP/UDP over IPv6 >> NETIF_F_HW_CSUM - device can checksum all packets > > I fail to see how defining a flag to mean one thing complicates things.
b/c we are talking on offloading IP, TCP, UDP and friends checksum -- something the networking stack does since 1991 or alike, and I don't see the point to go any further from where they are. > Plus, the proposed patch doesn't even follow what the network stack does. To make it clear, I didn't say that the proposed patch did what I sketched, I provided a response to you and a reviewer comment in the same reply... -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
