On Fri, 25 Sep 2015, Or Gerlitz wrote: > On Thu, Sep 24, 2015 at 8:00 PM, Christoph Lameter <[email protected]> wrote: > > Ok here is the fixed up and tested V2 of the patch. Can this go in with > > Doug's patch? > > > Repeating myself... do you find some over complexity in Erez's > implementation? what's the rational for not using his patch and yes > using yours? Erez and Co were very busy with some internal deadlines > and he's now OOO (it's a high Holiday season now) - will be able to > review your patch once he's back (Oct 6, I believe). It seems that the > patch does the job, but there are locking/contexts and such to > consider here, so I can't just ack it, have you passed it through > testing?
Yes the patch introduces a new callback and creates workqueues that recheck conditions etc etc. Makes it difficult to review and potentially creates new race conditions. I'd rather have a straightforward solution. -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
