On Tue, Oct 27, 2015 at 9:04 PM, Leon Romanovsky <[email protected]> wrote:
> On Tue, Oct 27, 2015 at 02:53:01PM +0200, Eran Ben Elisha wrote:
> ...
>> +enum ibv_qp_create_flags {
>> +     IBV_QP_CREATE_BLOCK_SELF_MCAST_LB       = 1 << 1,
>>  };
>>
> I'm sure that I'm missing something important, but why did it start
> from shift 1 and not shift 0?
> ....

QP creation flags are available for kernel QP.
The purpose of this patch was to expose QP creation flag of  MC LB
prevention to user space.

from include/rdma/ib_verbs.h,
enum ib_qp_create_flags {
...
IB_QP_CREATE_BLOCK_MULTICAST_LOOPBACK   = 1 << 1,
...
}

It is better to keep the same values in user space flags.

Eran.

>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
>> the body of a message to [email protected]
>> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to [email protected]
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to