On Mon, Nov 02, 2015 at 07:52:05PM -0500, Doug Ledford wrote: > It shouldn't be. I reviewed those changes and they looked right (given > the limitations). All you needed was to boot with nopat on the kernel > command line to get the old kernel behavior and it would continue to > work as before, and it would print out a message telling you to do so if > you hadn't already.
Alright, that was done after it was pretty clear the driver was useless and I stopped looking at that part of the series. I don't know why we made Luis jump through such hoops instead of just deleting it right then and there. > > For amso1100, kernel ULPs has never been its target. Didn't we only > > recently got any support for iWARP in iSER? I don't like that reasoning. In 4.4 we expect some ULPs to work on iWarp, and amso110 can't do it. That is a big reason why the driver is getting chopped. > > The reason I lobbied to get rid of them is specifically because they > > don't work and maintaining them (ie the driver and the single-use ULP > > codepath side) is a huge pain. Keeping them around and keeping them > > compiling defeats the entire point. Just delete them, we don't need to > > wait for 4.6. > > That's not true. User space continues to work, and amso1100 shouldn't > be greatly negatively impacted by recent changes. Nor should ipath. So what if user space works? The kernel consumers are known broken. We've commited to removing the driver from the kernel. We have support of the driver authors to do this. We have found no users or testers. We've committed to removing the ULP support (ie MR-only code is being ripped out). *WHY* spend an ounce of time fixing up code that *NO-ONE* will ever even run? Wasted effort. Just delete them now. Jason -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
