> On Nov 24, 2015, at 3:02 PM, Christoph Hellwig <[email protected]> wrote: > > On Tue, Nov 24, 2015 at 09:24:51AM -0500, Chuck Lever wrote: >> There is only one (new) call site that needs it. I can simplify >> this patch as Sagi suggested before, but it seems silly to >> introduce the extra clutter of adding a gfp_t argument >> everywhere. > > We a) generally try to pass the gfp_t around if we expect calling > contexts to change, and b the changes to the 6 callers are probably > still smaller than this patch :)
I’ll post a v2 early next week. It will be smaller and simpler. >>> And if we have any way to avoid the __GFP_NOFAIL >>> I'd really appreciate if we could give that a try. >> >> I???m not introducing the flag here. >> >> Changing all the svc_rdma_get_context() call sites to handle >> allocation failure (when it is already highly unlikely) is >> a lot of needless work, IMO, and not related to supporting >> bi-directional RPC. > > Ok. -- Chuck Lever -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
