On Tue, Dec 08, 2015 at 02:24:55PM -0500, ira.weiny wrote: > On Mon, Dec 07, 2015 at 01:54:39PM -0700, Jason Gunthorpe wrote: > > On Mon, Dec 07, 2015 at 03:49:12PM -0500, Dennis Dalessandro wrote: > > > /* A multicast address requires a GRH (see ch. 8.4.1). */ > > > - if (ah_attr->dlid >= QIB_MULTICAST_LID_BASE && > > > - ah_attr->dlid != QIB_PERMISSIVE_LID && > > > + if (ah_attr->dlid >= be16_to_cpu(IB_MULTICAST_LID_BASE) && > > > + ah_attr->dlid != be16_to_cpu(IB_LID_PERMISSIVE) && > > > > Uh cpu_to_be16 please.. > > But, the defines are big endian and the dlid here is cpu endian.
Hurm, I can't even find the patch that adds IB_MULTICAST_LID_BASE.. But I believe you, and think that is pretty gross to have the constant be BE when typical uses like this are CPU.. Jason -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
