On Tue, Jan 05, 2016 at 03:24:15PM +0100, Bart Van Assche wrote: > The target core guarantees that shutdown_session() is only invoked > once per session. This means that the ib_srpt target driver doesn't > have to track whether or not shutdown_session() has been called. > Additionally, ensure that target_sess_cmd_list_set_waiting() is > called before target_wait_for_sess_cmds() by moving it into > srpt_release_channel_work().
Looks good, Reviewed-by: Christoph Hellwig <h...@lst.de> Mote that now most drivers return either always return 0 or 1 from shutdown_session, so it might be worth to investigate if we can get rid of this method in the future. Minor nitpick below: > static int srpt_shutdown_session(struct se_session *se_sess) > { > return true; > } Given that the function returns in this really should be 1 in instead of true, but it's not really worth respinning the patch just for this. -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html