Hi Laurent,
On Mon, Feb 15, 2016 at 1:35 PM, Laurent Pinchart
<[email protected]> wrote:
>> > --- /dev/null
>> > +++ b/Documentation/devicetree/bindings/media/renesas,fcp.txt
>> > @@ -0,0 +1,24 @@
>> > +Renesas R-Car Frame Compression Processor (FCP)
>> > +-----------------------------------------------
>> > +
>> > +The FCP is a companion module of video processing modules in the Renesas
>> > R-Car
>> > +Gen3 SoCs. It provides data compression and decompression, data caching,
>> > and
>> > +converting of AXI transaction in order to reduce the memory bandwidth.
>>
>> "conversion"?
>>
>> > +
>> > +There are three types of FCP whose configuration and behaviour highly
>> > depend +on the module they are paired with.
>> > +
>> > + - compatible: Must be one of the following
>> > + - "renesas,fcpv" for the 'FCP for VSP' device
>>
>> Any chance this module can turn up in another SoC later? I guess yes.
>
> It's not just that it can, it will.
>
>> What about future-proofing using "renesas,r8a7795-fcpv" and "renesas,rcar-
>> gen3-fcpv"?
>
> Given that the device currently has registers and clock only, I wanted to keep
> the DT bindings simple. My plan is to introduce new compat strings later as
> needed, if needed, when incompatible FCP instances will be introduced. Feel
> free to challenge that :-)
I'm afraid that will be too late.
How are you gonna distinguish the new and incompatible variants from the
r8a7795 variant? Ah, by using "renesas,PartOfTheMonth-fcpv"?
So why not use "renesas,r8a7795-fcpv" now?
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
