Hi Wolfram,
On Thu, Mar 17, 2016 at 10:54 PM, Wolfram Sang <[email protected]> wrote:
> +++ b/Documentation/devicetree/bindings/watchdog/renesas-rwdt.txt
> @@ -0,0 +1,20 @@
> +Renesas RCLK Watchdog Timer (RWDT) Controller
> +
> +Required properties:
> +- compatible : Should be "renesas,r8a7795-rwdt", or "renesas,rcar-gen3-rwdt"
Please make the family-specific compatible value mandatory. Something
like:
+ When compatible with the generic version, nodes must list the SoC-specific
+ version corresponding to the platform first, followed by the generic
+ version.
> +- reg : Should contain WDT registers location and length
> +- clocks : the clock feeding the watchdog timer.
> +
> +Optional properties:
> +- timeout-sec : Contains the watchdog timeout in seconds
> +- power-domains : the power domain the RWDT belongs to
> +
> +Examples:
> +
> + wdt0: wdt@e6020000 {
> + compatible = "renesas,rwdt-r8a7795";
Old scheme + missing family-specific compatible value:
compatible = "renesas,r8a7795-rwdt", "renesas,rcar-gen3-rwdt";
> + reg = <0 0xe6020000 0 0x0c>;
> + clocks = <&cpg CPG_MOD 402>;
> + power-domains = <&cpg>;
> + timeout-sec = <60>;
> + };
> --- /dev/null
> +++ b/drivers/watchdog/renesas_rwdt.c
> +static const struct of_device_id rwdt_ids[] = {
> + { .compatible = "renesas,r8a7795-rwdt", },
... and then you can drop the r8a7795-specific match value from the driver.
> + { .compatible = "renesas,rcar-gen3-rwdt", },
> + { /* sentinel */ }
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
