Hi Dirk,
On Wed, May 11, 2016 at 7:29 AM, Dirk Behme <[email protected]> wrote:
> --- /dev/null
> +++ b/drivers/misc/boot-mode-reg/core.c
> +/**
> + * boot_mode_reg_set() - record boot mode register value
> + * @mode: implementation-dependent boot mode register value
> + *
> + * Records the boot mode register value which may subsequently
> + * be retrieved using boot_mode_reg_get().
> + *
> + * return: 0 on success
> + */
> +int boot_mode_reg_set(u32 mode)
> +{
> + int err = -EBUSY;
> +
> + mutex_lock(&boot_mode_mutex);
> + if (!boot_mode_is_set) {
You've dropped the check for calling this function a subsequent time with
a different value of mode?
> + boot_mode = mode;
> + boot_mode_is_set = true;
> + err = 0;
> + }
> + mutex_unlock(&boot_mode_mutex);
> + return err;
> +}
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
