Hi Mark

> > +int asoc_simple_card_parse_card_widgets(struct snd_soc_card *card,
> > +                                   char *prefix)
> > +{
> > +   struct device_node *np = card->dev->of_node;
> > +   char prop[128];
> > +   int ret = 0;
> > +
> > +   snprintf(prop, sizeof(prop), "%swidgets", prefix);
> > +
> > +   if (of_property_read_bool(np, prop))
> > +           ret = snd_soc_of_parse_audio_simple_widgets(card, prop);
> > +
> > +   return ret;
> > +}
> > +EXPORT_SYMBOL_GPL(asoc_simple_card_parse_card_widgets);
> 
> This seems like an extremely thin wrapper around existing core
> functionality, shouldn't we just be adding the property check into the
> core?

OK, will do in v2

Reply via email to