On 09/06/16 09:08, Geert Uytterhoeven wrote: > Hi Linus, Ben, > > On Wed, Jun 8, 2016 at 2:08 PM, Linus Walleij <[email protected]> > wrote: >> On Tue, Jun 7, 2016 at 7:33 PM, Ben Dooks <[email protected]> wrote: >> >>> Fix warnings about emev2_pinmux_info and r8a7779_pinmux_info >>> by using core.h instead of sh_pfc.h in these files. This gives >>> the declarations of the two structures and removes the following >>> warnings: >>> >>> drivers/pinctrl/sh-pfc/pfc-emev2.c:1695:30: warning: symbol >>> 'emev2_pinmux_info' was not declared. Should it be static? >>> drivers/pinctrl/sh-pfc/pfc-r8a7779.c:3888:30: warning: symbol >>> 'r8a7779_pinmux_info' was not declared. Should it be static? >>> >>> Signed-off-by: Ben Dooks <[email protected]> > > Ben: Thanks for your patch! > >> >> Geert/Laurent: >> >> - take a look at this patch > > These are fixes for sparse warnings, and look fine to me. > However, it seems "core.h" should be included by all the remaining > drivers/pinctrl/sh-pfc/pfc-sh* files for ARCH=sh, too. > At which point I start to question: why not merge core.h with sh_pfc.h? > >> - shall I apply this directly? > > i could take it through sh-pfc-for-v4.8. > I expect more pfc stuff to follow soon anyway.
Up to you what you want to do, thought these items should be fixed. -- Ben Dooks http://www.codethink.co.uk/ Senior Engineer Codethink - Providing Genius
