Hi Laurent,
On Fri, Jun 10, 2016 at 2:16 PM, Laurent Pinchart
<[email protected]> wrote:
> On Friday 10 Jun 2016 12:05:02 Geert Uytterhoeven wrote:
>> The Renesas Pin Function Controller uses two header files:
>> - sh_pfc.h, for use by both core code and SoC-specific drivers,
>> - core.h, for internal use by the core code only.
>>
>> Several SoC-specific drivers include core.h, as they need the sh_pfc
>> structure, which is passed explicitly to the various SoC-specific
>> callbacks, and used there.
>>
>> Hence move its definition from core.h to sh_pfc.h, and remove the
>> inclusion of core.h from all SoC-specific files.
>
> The idea behind sh_pfc.h is to store all structures and macros needed by the
> SoC drivers to define SoC data, in order to keep core.h clean. It you move
So should there be 3 includes:
1. structures and macros needed by the SoC drivers to define SoC data,
2. internal API,
3. API for users (SoC-specific drivers)?
> most of core.h to sh_pfc.h I'd rather merge the two files.
That's the other option...
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
