On Wed, Jun 15, 2016 at 01:01:56PM +0900, Simon Horman wrote: > Rename the source file for DMA for Renesas SDHI as a follow-up to attaching > DMA code to the renesas_sdhi driver rather than the tmio_core driver. > > Signed-off-by: Simon Horman <[email protected]> > --- > drivers/mmc/host/Makefile | 2 +- > drivers/mmc/host/{tmio_mmc_dma.c => renesas_sdhi_dma.c} | 0 > 2 files changed, 1 insertion(+), 1 deletion(-) > rename drivers/mmc/host/{tmio_mmc_dma.c => renesas_sdhi_dma.c} (100%)
Because of the modularization, I think the rename makes a lot of sense here and is worth renaming the functions inside, too. What do you think? I think the rename should include the DMA type used, though. Like 'renesas_sdhi_sysc_dmac.c' here and 'renesas_sdhi_internal_dmac.c' for the new one in the next patch? > > diff --git a/drivers/mmc/host/Makefile b/drivers/mmc/host/Makefile > index 4f7903fbef26..0ea7fb6f3d5e 100644 > --- a/drivers/mmc/host/Makefile > +++ b/drivers/mmc/host/Makefile > @@ -38,7 +38,7 @@ obj-$(CONFIG_MMC_TMIO) += tmio_mmc.o > obj-$(CONFIG_MMC_TMIO_CORE) += tmio_mmc_core.o > tmio_mmc_core-y := tmio_mmc_pio.o > obj-$(CONFIG_MMC_SDHI) += renesas_sdhi.o > -renesas_sdhi-$(subst m,y,$(CONFIG_MMC_SDHI_DMA)) += tmio_mmc_dma.o > +renesas_sdhi-$(subst m,y,$(CONFIG_MMC_SDHI_DMA)) += renesas_sdhi_dma.o > obj-$(CONFIG_MMC_CB710) += cb710-mmc.o > obj-$(CONFIG_MMC_VIA_SDMMC) += via-sdmmc.o > obj-$(CONFIG_SDH_BFIN) += bfin_sdh.o > diff --git a/drivers/mmc/host/tmio_mmc_dma.c > b/drivers/mmc/host/renesas_sdhi_dma.c > similarity index 100% > rename from drivers/mmc/host/tmio_mmc_dma.c > rename to drivers/mmc/host/renesas_sdhi_dma.c > -- > 2.1.4 >
signature.asc
Description: PGP signature
