On Fri, Sep 30, 2016 at 3:46 PM, Jithin T Raj <[email protected]> wrote:
> I would like to give support to RGB LVDS BRIDGE RCAR E2
>
> I am attaching the patch file..can you please review it and let me know the
> status.is it correct or not?
Please don't attach patches, but inline them, so we can easily add review
comments.
> diff --git a/a/r8a7794-alt.dts b/b/r8a7779-marzen.dts
This doesn't look like a patch generated by "git diff"...
> index 383ad79..b795da6 100644
> --- a/a/r8a7794-alt.dts
> +++ b/b/r8a7779-marzen.dts
> @@ -1,7 +1,8 @@
> /*
> - * Device Tree Source for the Alt board
> + * Device Tree Source for the Marzen board
Are you trying to replace arch/arm/boot/dts/r8a7794-alt.dts by
arch/arm/boot/dts/r8a7779-marzen.dts? That won't work...
Please try adding an "lvds-encoder" block to arch/arm/boot/dts/r8a7794-alt.dts,
as exists in arch/arm/boot/dts/r8a7779-marzen.dts.
You want to replace "thc63lvdm83d" by "thc63lvdm87", though.
You said you added "thc63lvdm87" in "drivers/gpu/drm/rcar-du/rcar_du_kms.c",
so that part should be fine.
Good luck!
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
