Hello Geert, Thank you for the review.
> -----Original Message----- > From: [email protected] > [mailto:[email protected]] On Behalf Of Geert Uytterhoeven > Sent: 23 November 2016 08:14 > To: Chris Paterson <[email protected]> > Cc: Laurent Pinchart <[email protected]>; Geert > Uytterhoeven <[email protected]>; Linus Walleij > <[email protected]>; Linux-Renesas <linux-renesas- > [email protected]>; [email protected]; Ramesh > Shanmugasundaram <[email protected]> > Subject: Re: [PATCH 1/2] pinctrl: sh-pfc: r8a7796: Add CAN support > > Hi Chris, > > On Tue, Nov 22, 2016 at 2:49 PM, Chris Paterson > <[email protected]> wrote: > > Signed-off-by: Ramesh Shanmugasundaram > > <[email protected]> > > Signed-off-by: Chris Paterson <[email protected]> > > Reviewed-by: Geert Uytterhoeven <[email protected]> > > BTW, as all patches in this series were Signed-off-by Ramesh first, does that > mean he's the author, and you should have added his From: line, too? Technically I authored these patches, but they are direct ports from Ramesh's r8a7795 patches [1][2]. [1] a4d9791 pinctrl: sh-pfc: r8a7795: Add CAN support [2] 4412bb5 pinctrl: sh-pfc: r8a7795: Add CAN FD support Apologies for not making this clear in the cover letter. Kind regards, Chris > > Thanks! > > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux- > m68k.org > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like > that. > -- Linus Torvalds
