Hi Chris
> > > I don't think using global variable is a good idea.
> > > For example, how about add reg_width_8bit into mstp_clock_group, and
> > > cpg_mstp_read/write requests it, or something like that ?
> >
> > If I make a separate CLK_OF_DECLARE like this:
> >
> > static void __init cpg_mstp_clocks_init8(struct device_node *np) {
> > reg_width_8bit = true;
> > cpg_mstp_clocks_init(np);
> > }
> > CLK_OF_DECLARE(cpg_mstp_clks8, "renesas,r7s72100-mstp-clocks",
> > cpg_mstp_clocks_init8);
> >
> > The only way I can pass the 8-bit/32-bit choice into cpg_mstp_clocks_init()
> > is using a global variable.
>
> How about this ?
> # I didn't test this, compile test only
Oops, I misread your email.
Yes, your 2nd idea (= using true, false) is better idea.
Best regards
---
Kuninori Morimoto
