Hi Magnus,

On Mon, Mar 20, 2017 at 9:49 AM, Magnus Damm <magnus.d...@gmail.com> wrote:
> From: Magnus Damm <damm+rene...@opensource.se>
>
> Update the r8a7795 SATA device node to use a 2MiB I/O space as specified
> in the "72. Serial-ATA" section of R-Car-Gen3-rev0.52E.pdf
>
> Signed-off-by: Magnus Damm <damm+rene...@opensource.se>

Reviewed-by: Geert Uytterhoeven <geert+rene...@glider.be>

> --- 0001/arch/arm64/boot/dts/renesas/r8a7795.dtsi
> +++ work/arch/arm64/boot/dts/renesas/r8a7795.dtsi       2017-03-20 
> 17:41:36.390607110 +0900
> @@ -1209,7 +1209,7 @@
>
>                 sata: sata@ee300000 {
>                         compatible = "renesas,sata-r8a7795";
> -                       reg = <0 0xee300000 0 0x1fff>;
> +                       reg = <0 0xee300000 0 0x200000>;

While the datasheet does mention the 2 MiB area, it also says no (write)
access should be made to registers not listed in the table, while these are
all covered by the existing area?

BTW, what about the Reference Clock Source Select Register, which lies
in a further undocumented area?

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Reply via email to