On Fri, Mar 17, 2017 at 04:52:57PM +0100, Niklas Söderlund wrote: > Record how many TSCs are found in struct rcar_gen3_thermal_priv, this is > needed to be able to add hardware interrupts for trip points later. Also > add a check to make sure at least one TSC is found. > > Signed-off-by: Niklas Söderlund <[email protected]> > --- > drivers/thermal/rcar_gen3_thermal.c | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/drivers/thermal/rcar_gen3_thermal.c > b/drivers/thermal/rcar_gen3_thermal.c > index 9b6bc03dd142a8dd..3b6e85abfadc61a3 100644 > --- a/drivers/thermal/rcar_gen3_thermal.c > +++ b/drivers/thermal/rcar_gen3_thermal.c > @@ -74,6 +74,7 @@ struct rcar_gen3_thermal_tsc { > }; > > struct rcar_gen3_thermal_priv { > + unsigned int num_tscs; > struct rcar_gen3_thermal_tsc *tscs[TSC_MAX_NUM]; > }; > > @@ -305,6 +306,12 @@ static int rcar_gen3_thermal_probe(struct > platform_device *pdev) > goto error_unregister; > } > tsc->zone = zone; > + priv->num_tscs++; > + } > + > + if (!priv->num_tscs) { > + ret = -ENODEV; > + goto error_unregister;
I would have probably done 'priv->num_tscs = i;' after the loop instead of 'priv->num_tscs++;' in the loop, but that is super-minor. Reviewed-by: Wolfram Sang <[email protected]>
signature.asc
Description: PGP signature
