Hi Vinod,
On Fri, May 19, 2017 at 5:51 AM, Vinod Koul <[email protected]> wrote:
> On Tue, May 16, 2017 at 01:09:15AM +0200, Niklas Söderlund wrote:
>> The IRQ number is needed after probe to be able to add synchronisation
>> points in other places in the driver when freeing resources and to
>> implement a device_synchronize() callback. Store the IRQ number in the
>> struct rcar_dmac_chan so that it can be used later.
>>
>> Signed-off-by: Niklas Söderlund <[email protected]>
>> ---
>> drivers/dma/sh/rcar-dmac.c | 13 ++++++++-----
>> 1 file changed, 8 insertions(+), 5 deletions(-)
>>
>> diff --git a/drivers/dma/sh/rcar-dmac.c b/drivers/dma/sh/rcar-dmac.c
>> index db41795fe42ae6ed..c68c3336bdad44df 100644
>> --- a/drivers/dma/sh/rcar-dmac.c
>> +++ b/drivers/dma/sh/rcar-dmac.c
>> @@ -144,6 +144,7 @@ struct rcar_dmac_chan_map {
>> * @chan: base DMA channel object
>> * @iomem: channel I/O memory base
>> * @index: index of this channel in the controller
>> + * @irq: channel IRQ
>> * @src: slave memory address and size on the source side
>> * @dst: slave memory address and size on the destination side
>> * @mid_rid: hardware MID/RID for the DMA client using this channel
>> @@ -161,6 +162,7 @@ struct rcar_dmac_chan {
>> struct dma_chan chan;
>> void __iomem *iomem;
>> unsigned int index;
>> + int irq;
>
> Thats a bit odd choice to store per ch, I would have stored in rcar_dmac.
> Any specific reason, do we have per ch irq here?
Yes, each channel has its own interrupt.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
