Hi Ramesh,
On Tue, Jun 13, 2017 at 11:10 AM, Ramesh Shanmugasundaram
<[email protected]> wrote:
> This patch adds driver support for the MAX2175 chip. This is Maxim
> Integrated's RF to Bits tuner front end chip designed for software-defined
> radio solutions. This driver exposes the tuner as a sub-device instance
> with standard and custom controls to configure the device.
>
> Signed-off-by: Ramesh Shanmugasundaram
> <[email protected]>
> ---
> Hi Hans,
>
> As requested, here is the v9 of this patch alone implementing the work
> around to avoid the sparse warning.
>
>
> https://www.mail-archive.com/[email protected]/msg15138.html
>
> For some reason, I could not reproduce this warning in my setup :-(
>
> Thanks,
> Ramesh.
>
> v9:
> - Work around to avoid a sparse warning generated because of
> regmap_read_poll_timeout macro implementation.
> +/* Checks expected pattern every msec until timeout */
> +static int max2175_poll_timeout(struct max2175 *ctx, u8 idx, u8 msb, u8 lsb,
> + u8 exp_bitval, u32 timeout_ms)
> +{
> + unsigned int val;
> +
> + /*
> + * The brackets around the last parameter is a work around to avoid
> + * the sparse tool warning. The ideal fix is to use brackets for the
> + * last parameter of regmap_read_poll_timeout macro.
> + */
> + return regmap_read_poll_timeout(ctx->regmap, idx, val,
> + (max2175_get_bitval(val, msb, lsb) == exp_bitval),
> + 1000, (timeout_ms * 1000));
I don't think that issue should be fixed here, so I prefer v8.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
