Hi Jacopo,

Thanks for your patch.

On 2017-06-19 19:04:39 +0200, Jacopo Mondi wrote:
> Add parallel video input port to VIN channel #4 and link it to camera
> module remote endpoint.
> 
> Signed-off-by: Jacopo Mondi <[email protected]>
> ---
>  arch/arm64/boot/dts/renesas/r8a7796-salvator-x.dts | 23 
> ++++++++++++++++++++++
>  1 file changed, 23 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/renesas/r8a7796-salvator-x.dts 
> b/arch/arm64/boot/dts/renesas/r8a7796-salvator-x.dts
> index 41c94c3..b69fe4a 100644
> --- a/arch/arm64/boot/dts/renesas/r8a7796-salvator-x.dts
> +++ b/arch/arm64/boot/dts/renesas/r8a7796-salvator-x.dts
> @@ -379,6 +379,29 @@
>  
>  &vin4 {
>       status = "okay";
> +
> +     #address-cells = <1>;
> +     #size-cells = <0>;
> +
> +     ports{
> +             port@2 {

The Gen3 code is not yet upstream so I don't blame you for not reading 
rcar_vin.txt [1] :-) I did try to prepare the DT bindings for the 
digital input and that it should be as similar as possible to the Gen2 
case. There for please use port@0 for the digital input, at least until 
someone finds a flaw in the proposed DT bindings for Gen3.

1. Documentation/devicetree/bindings/media/rcar_vin.txt from the patch 
   series '[PATCH v4 00/27] rcar-vin: Add Gen3 with media controller 
   support'.

> +                     #address-cells = <1>;
> +                     #size-cells = <0>;
> +
> +                     reg = <2>;
> +
> +                     vin4_in: endpoint@0 {
> +                             reg = <0>;
> +
> +                             bus_width = <8>;
> +                             hsync-active = <1>;
> +                             vsync-active = <1>;
> +                             data-shift = <8>;
> +
> +                             remote-endpoint = <&mt9m111_out>;
> +                     };
> +             };
> +     };
>  };
>  
>  &vin5 {
> -- 
> 2.7.4
> 

-- 
Regards,
Niklas Söderlund

Reply via email to