Hi Geert,
Thanks for the review.
> -----Original Message-----
> From: [email protected] [mailto:[email protected]]
> On Behalf Of Geert Uytterhoeven
> Sent: 10 July 2017 08:55
> To: Biju Das <[email protected]>
> Cc: Rob Herring <[email protected]>; Mark Rutland
> <[email protected]>; Russell King <[email protected]>; Sergei
> Shtylyov <[email protected]>; Simon Horman
> <[email protected]>; Magnus Damm <[email protected]>; Chris
> Paterson <[email protected]>; [email protected]; Linux-
> Renesas <[email protected]>; linux-arm-
> [email protected]
> Subject: Re: [PATCH v 1/2] ARM: dts: r8a7743: Add Ethernet AVB support
>
> Hi Biju,
>
> On Fri, Jul 7, 2017 at 3:12 PM, Biju Das <[email protected]> wrote:
> > Add Ethernet AVB support for r8a7743 SoC.
> >
> > Signed-off-by: Biju Das <[email protected]>
> > Reviewed-by: Chris Paterson <[email protected]>
>
> With the minor nit below fixed:
> Reviewed-by: Geert Uytterhoeven <[email protected]>
>
> > --- a/arch/arm/boot/dts/r8a7743.dtsi
> > +++ b/arch/arm/boot/dts/r8a7743.dtsi
> > @@ -605,6 +605,19 @@
> > #size-cells = <0>;
> > status = "disabled";
> > };
> > +
> > + avb: ethernet@e6800000 {
> > + compatible = "renesas,etheravb-r8a7743",
> > + "renesas,etheravb-rcar-gen2";
> > + reg = <0 0xe6800000 0 0x800>, <0 0xee0e8000 0
> > 0x4000>;
> > + interrupts = <0 163 IRQ_TYPE_LEVEL_HIGH>;
>
OK. I will fix this.
> s/0/GIC_SPI/
>
> Gr{oetje,eeting}s,
>
> Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-
> m68k.org
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like
> that.
> -- Linus Torvalds
Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End,
Buckinghamshire, SL8 5FH, UK. Registered in England & Wales under Registered
No. 04586709.
