Hi Geert,
On Wednesday, July 12, 2017 1, Geert Uytterhoeven wrote:
> > Reported-by: Dan Carpenter <dan.carpen...@oracle.com>
> > Fixes: 8185e51f358a: ("mmc: tmio-mmc: add support for 32bit data port")
> > Signed-off-by: Chris Brandt <chris.bra...@renesas.com>
>
> Reviewed-by: Geert Uytterhoeven <geert+rene...@glider.be>
As always, thank you for your review.
> > if (is_read) {
> > sd_ctrl_read32_rep(host, CTL_SD_DATA_PORT,
> > - (u32 *)data, 1);
> > + &data, 1);
>
> I would use the opportunity to merge the two above lines, now they fit
> on a single line.
>
> > + memcpy(buf32, &data, count);
> > } else {
> > - memcpy(data, buf8, count);
> > + memcpy(&data, buf32, count);
> > sd_ctrl_write32_rep(host, CTL_SD_DATA_PORT,
> > - (u32 *)data, 1);
> > + &data, 1);
>
> Likewise.
Easy enough.
Done!
Thanks,
Chris
