Hi Kieran,

On Wednesday, 30 August 2017 17:31:11 EEST Kieran Bingham wrote:
> Hi Laurent,
> 
> Clearly I hit send too early <pre-testing> :-D
> 
> On 30/08/17 15:16, Kieran Bingham wrote:
> > Hi Laurent,
> > 
> > On 24/08/17 10:30, Laurent Pinchart wrote:
> >> Signed-off-by: Laurent Pinchart <[email protected]>
> > 
> > Nothing scary in here. Just pending testing the other patchset/issues,
> > then I can run this through as well for a tested-by.
> > 
> > Meanwhile:
> > 
> > Reviewed-by: Kieran Bingham <[email protected]>
> > 
> >> ---
> >> 
> >>  tests/vsp-unit-test-0024.sh | 45
> >>  +++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 45
> >>  insertions(+)
> >>  create mode 100755 tests/vsp-unit-test-0024.sh
> >> 
> >> diff --git a/tests/vsp-unit-test-0024.sh b/tests/vsp-unit-test-0024.sh
> >> new file mode 100755
> >> index 000000000000..036429254a8f
> >> --- /dev/null
> >> +++ b/tests/vsp-unit-test-0024.sh
> >> @@ -0,0 +1,45 @@
> >> +#!/bin/sh
> >> +
> >> +#
> >> +# Test composition through the BRS in RGB and YUV formats.
> >> +#
> >> +
> >> +source vsp-lib.sh
> 
> Please can this be:
> . ./vsp-lib.sh

Sure, it's now fixed in my tree, I'm just waiting for your Tested-by: tag 
before pushing it out.

> >> +
> >> +features="rpf.0 rpf.1 brs wpf.0"
> >> +formats="RGB24 YUV444M"
> >> +
> >> +test_brs() {
> >> +  local format=$1
> >> +  local ninputs=$2
> >> +
> >> +  test_start "BRS in $format with $ninputs inputs"
> >> +
> >> +  pipe_configure rpf-brs $ninputs
> >> +  format_configure rpf-brs $format 1024x768 $ninputs
> >> +
> >> +  local input
> >> +  for input in `seq 0 1 $((ninputs-1))` ; do
> >> +          vsp_runner rpf.$input &
> >> +  done
> >> +  vsp_runner wpf.0
> >> +
> >> +  local result=$(compare_frames)
> >> +
> >> +  test_complete $result
> >> +}
> >> +
> >> +test_main() {
> >> +  local num_inputs=2
> >> +  local format
> >> +  local ninputs
> >> +
> >> +  for format in $formats ; do
> >> +          for ninputs in `seq $num_inputs` ; do
> >> +                  test_brs $format $ninputs
> >> +          done
> >> +  done
> >> +}
> >> +
> >> +test_init $0 "$features"
> >> +test_run

-- 
Regards,

Laurent Pinchart

Reply via email to