Hi Geert,
Thank you for the review.
On 20.09.2017 15:59, Geert Uytterhoeven wrote:
Hi Vladimir,
On Thu, Sep 7, 2017 at 12:36 AM, Vladimir Barinov
<[email protected]> wrote:
This supports USB2 PHY channel #0 on ULCB Kingfisher board
Signed-off-by: Vladimir Barinov <[email protected]>
Reviewed-by: Geert Uytterhoeven <[email protected]>
index ca8de1a..0854600 100644
--- a/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi
+++ b/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi
@@ -60,6 +60,11 @@
groups = "scif1_data_b";
function = "scif1";
};
+
+ usb0_pins: usb0 {
+ groups = "usb0";
+ function = "usb0";
+ };
};
&scif1 {
@@ -68,3 +73,10 @@
status = "okay";
};
+
+&usb2_phy0 {
+ pinctrl-0 = <&usb0_pins>;
+ pinctrl-names = "default";
+
Don't you need
vbus-supply = <&vbus0_usb2>;
with vbus0_usb2 a fixed regulator controlled by GPIO P11 (OTG_EXTLPn) from
GPIO expander U11 (TCA9539)?
May be optional, though. salvator-common.dtsi has it.
Yes, I need this gpio.
I need both OTG_EXTLPn and OTG_OFFVBUSn from the same gpio expander.
I've been considering to use either vbus-supply + gpio hog or use gpio
hog for both of them for consistency.
What do you think about this?
I plan to add these gpios control as a separate patch.
--
Regards,
Vladimir
