On 10/10/2017 04:58 PM, Geert Uytterhoeven wrote:
> Add a device node for the ROHM BD9571MWV PMIC, based on the example in
> the DT binding documentation, but using INTC-EX instead.
> 
> Signed-off-by: Geert Uytterhoeven <[email protected]>
> ---
> Do we need to describe more regulators?

To my knowledge, no.

> This depends on:
>   - [PATCH] pinctrl: sh-pfc: r8a7796: Add support for INTC-EX IRQ pins,
>   - [PATCH] pinctrl: sh-pfc: r8a7795: Add INTC-EX pins, groups and
>     function.
> ---
>  arch/arm64/boot/dts/renesas/salvator-common.dtsi | 29 
> ++++++++++++++++++++++++
>  1 file changed, 29 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/renesas/salvator-common.dtsi 
> b/arch/arm64/boot/dts/renesas/salvator-common.dtsi
> index 3dcb26b1cb6bdec0..c171718bac7f52a1 100644
> --- a/arch/arm64/boot/dts/renesas/salvator-common.dtsi
> +++ b/arch/arm64/boot/dts/renesas/salvator-common.dtsi
> @@ -353,6 +353,30 @@
>  
>  &i2c_dvfs {
>       status = "okay";
> +
> +     pmic: pmic@30 {
> +             pinctrl-0 = <&irq0_pins>;
> +             pinctrl-names = "default";
> +
> +             compatible = "rohm,bd9571mwv";
> +             reg = <0x30>;
> +             interrupt-parent = <&intc_ex>;

Shouldn't this be gpio2 ? Why intc-ex ?

> +             interrupts = <0 IRQ_TYPE_LEVEL_LOW>;
> +             interrupt-controller;
> +             #interrupt-cells = <2>;
> +             gpio-controller;
> +             #gpio-cells = <2>;
> +
> +             regulators {
> +                     dvfs: dvfs {
> +                             regulator-name = "dvfs";
> +                             regulator-min-microvolt = <750000>;
> +                             regulator-max-microvolt = <1030000>;
> +                             regulator-boot-on;
> +                             regulator-always-on;
> +                     };
> +             };
> +     };
>  };
>  
>  &ohci0 {
> @@ -407,6 +431,11 @@
>               function = "i2c2";
>       };
>  
> +     irq0_pins: irq0 {
> +             groups = "intc_ex_irq0";
> +             function = "intc_ex";
> +     };
> +
>       pwm1_pins: pwm1 {
>               groups = "pwm1_a";
>               function = "pwm1";
> 


-- 
Best regards,
Marek Vasut

Reply via email to