Hello Geert,
thank you for your comments.
>
> As the pin groups and functions are part of the stable DT ABI, you cannot just
> remove the can_clk* pins from can0_groups[], as that would break existing
> users.
>
> I would keep them, but add a comment "/* retained for backwards
> compatibility */".
>
> Adding a new can_clk_groups[] ...
>
> and can_clk function is OK, though.
>
> My comments apply to your r8a7794 patch, too. Except that on r8a7794 we
> didn't have CAN support in pfc-r8a7794.c before, but I would like to treat all
> R-Car Gen2 and RZ/G1 SoCs in the same way.
I'll send a v2 to fix this.
Thanks,
Fab
>
> Gr{oetje,eeting}s,
>
> Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 --
> [email protected]
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like
> that.
> -- Linus Torvalds
Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End,
Buckinghamshire, SL8 5FH, UK. Registered in England & Wales under Registered
No. 04586709.
