Hi Wolfram, On Wed, Nov 15, 2017 at 03:32:21PM +0100, Wolfram Sang wrote: > The datasheet was a bit vague, but after consultation with HW designers, > we came to the conclusion that we should set the SCP bit always when > dealing only with the ICE bit. A set SCP bit is ignored, and thus fine, > a cleared one may trigger STOP on the bus. > > Signed-off-by: Wolfram Sang <[email protected]> > --- > > Jacopo: another to test, please. On top of all the other patches. Thank you!
and for this one as well, on Migo-R no visible regressions. I2c sensor probes properly, and I can capture images. Tested-by: Jacopo Mondi <[email protected]> Thanks j > > drivers/i2c/busses/i2c-sh_mobile.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/i2c/busses/i2c-sh_mobile.c > b/drivers/i2c/busses/i2c-sh_mobile.c > index 9012d5f8fb38b8..c2841a4f5807c0 100644 > --- a/drivers/i2c/busses/i2c-sh_mobile.c > +++ b/drivers/i2c/busses/i2c-sh_mobile.c > @@ -604,10 +604,10 @@ static int start_ch(struct sh_mobile_i2c_data *pd, > struct i2c_msg *usr_msg, > > if (do_init) { > /* Initialize channel registers */ > - iic_wr(pd, ICCR, 0); > + iic_wr(pd, ICCR, ICCR_SCP); > > /* Enable channel and configure rx ack */ > - iic_wr(pd, ICCR, ICCR_ICE); > + iic_wr(pd, ICCR, ICCR_ICE | ICCR_SCP); > > /* Set the clock */ > iic_wr(pd, ICCL, pd->iccl & 0xff); > @@ -723,7 +723,7 @@ static int sh_mobile_i2c_xfer(struct i2c_adapter *adapter, > } > > /* Disable channel */ > - iic_wr(pd, ICCR, 0); > + iic_wr(pd, ICCR, ICCR_SCP); > > /* Disable clock and mark device as idle */ > pm_runtime_put_sync(pd->dev); > -- > 2.11.0 >
