On Wed, Nov 22, 2017 at 02:06:59PM +0100, Geert Uytterhoeven wrote: > Hi Sergei, > > On Thu, Nov 16, 2017 at 10:06 PM, Sergei Shtylyov > <[email protected]> wrote: > > Define the generic R8A77970 parts of the I2C[0-4] device node. > > > > Based on the original (and large) patch by Daisuke Matsushita > > <[email protected]>. > > > > Signed-off-by: Vladimir Barinov <[email protected]> > > Signed-off-by: Sergei Shtylyov <[email protected]> > > Thanks for your patch! > > > --- renesas.orig/arch/arm64/boot/dts/renesas/r8a77970.dtsi > > +++ renesas/arch/arm64/boot/dts/renesas/r8a77970.dtsi > > > @@ -483,5 +491,85 @@ > > #address-cells = <1>; > > #size-cells = <0>; > > }; > > + > > + i2c0: i2c@e6500000 { > > + compatible = "renesas,i2c-r8a77970", > > + "renesas,rcar-gen3-i2c"; > > + reg = <0 0xe6500000 0 0x40>; > > + interrupts = <GIC_SPI 287 IRQ_TYPE_LEVEL_HIGH>; > > + clocks = <&cpg CPG_MOD 931>; > > + power-domains = <&sysc 32>; > > + resets = <&cpg 931>; > > + dmas = <&dmac1 0x91>, <&dmac1 0x90>; > > Can't all five i2c interfaces be used with both dmac1 and dmac2? > > With that fixed: > Reviewed-by: Geert Uytterhoeven <[email protected]>
Hi Sergei, I have marked this series as "Changes Requested" in light of Geert's review above.
