Hello Geert, thank you for your feedback.
> Hi Fabrizio, > > On Wed, Dec 13, 2017 at 10:42 AM, Fabrizio Castro > <[email protected]> wrote: > >> On Tue, Dec 12, 2017 at 06:49:38PM +0000, Fabrizio Castro wrote: > >> > Add CMT[01] support to SoC DT. > >> > Signed-off-by: Fabrizio Castro <[email protected]> > >> > Reviewed-by: Biju Das <[email protected]> > >> > --- > >> > arch/arm/boot/dts/r8a7743.dtsi | 30 ++++++++++++++++++++++++++++++ > >> > 1 file changed, 30 insertions(+) > >> > >> I was expecting the cmt nodes to be "disabled" in the SoC file > >> and then enabled selectively in board files. Am I missing something? > > > > Since this component is just a compare and match timer, I thought there > > was no harm in enabling it by default in the SoC specific DT. > > The system will park it and leave its clock disabled until actually needed > > for something. > > The user can still disable it in the board specific DT if he/she doesn't > > mean to even have the option to use it. Do you prefer I left it > disabled by default? > > It's debatable (thus up to Simon the maintainer ;-). > For I/O devices, we disable them in the SoC .dtsi file. > For core infrastructure like interrupt, DMA, and GPIO controllers, we keep > them enabled. > > Timers are core functionality, but who's actually using these timers? I don't have a use case in mind unfortunately, but it's still core functionality and pretty harmless as far as I can tell. Let's see what Simon thinks about this. Thanks, Fab > > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- > [email protected] > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like > that. > -- Linus Torvalds [https://www2.renesas.eu/media/email/unicef_2017.jpg] This Christmas, instead of sending out cards, Renesas Electronics Europe have decided to support Unicef with a donation. For further details click here<https://www.unicef.org/> to find out about the valuable work they do, helping children all over the world. We would like to take this opportunity to wish you a Merry Christmas and a prosperous New Year. Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, Buckinghamshire, SL8 5FH, UK. Registered in England & Wales under Registered No. 04586709.
