Hello, On Friday, 15 December 2017 16:38:16 EET Sakari Ailus wrote: > Hi Jacopo, > > On Wed, Dec 13, 2017 at 07:26:18PM +0100, Jacopo Mondi wrote: > > Notifiers can be registered as root notifiers (identified by a 'struct > > v4l2_device *') or subdevice notifiers (identified by a 'struct > > v4l2_subdev *'). In order to identify a notifier no matter if it is root > > or not, add a 'struct fwnode_handle *owner' field, whose name can be > > printed out for debug purposes. > > > > Signed-off-by: Jacopo Mondi <jacopo+rene...@jmondi.org> > > You'll have struct device either through the v4l2_device or v4l2_subdev. Do > you need an additional field for this?
I agree with this comment. If there's a reason to add a new field, its life time constraints should be documented. The fwnodes are refcounted and you're not increasing the refcount here, you should explain why you don't need to. -- Regards, Laurent Pinchart
