Hi Geert, Thanks, I will send v2.
Regards, Biju > -----Original Message----- > From: [email protected] [mailto:[email protected]] > On Behalf Of Geert Uytterhoeven > Sent: 19 December 2017 11:45 > To: Biju Das <[email protected]> > Cc: Rob Herring <[email protected]>; Mark Rutland > <[email protected]>; Zhang Rui <[email protected]>; Eduardo > Valentin <[email protected]>; Simon Horman <[email protected]>; > Magnus Damm <[email protected]>; Chris Paterson > <[email protected]>; [email protected]; Linux-Renesas > <[email protected]>; Linux PM list <linux- > [email protected]> > Subject: Re: [PATCH 2/2] ARM: dts: r8a7743: Add thermal device to DT > > On Wed, Dec 13, 2017 at 11:57 AM, Biju Das <[email protected]> > wrote: > > This patch instantiates the thermal sensor module with thermal-zone > > support. > > > > This patch is based on the commit cac68a56e34b > > ("ARM: dts: r8a7791: enable to use thermal-zone") by Kuninori Morimoto. > > > > Signed-off-by: Biju Das <[email protected]> > > Reviewed-by: Fabrizio Castro <[email protected]> > > Reviewed-by: Geert Uytterhoeven <[email protected]> > > Minor nit below... > > > --- a/arch/arm/boot/dts/r8a7743.dtsi > > +++ b/arch/arm/boot/dts/r8a7743.dtsi > > @@ -250,6 +250,38 @@ > > resets = <&cpg 407>; > > }; > > > > + thermal: thermal@e61f0000 { > > + compatible = "renesas,thermal-r8a7743", > > + "renesas,rcar-gen2-thermal", > > + "renesas,rcar-thermal"; > > + reg = <0 0xe61f0000 0 0x14>, <0 0xe61f0100 0 > > + 0x38>; > > <0 0xe61f0000 0 0x10>? > > The register at offset 0x10 seems to exist on R-Mobile APE6 only, but all > R-Car > Gen2 .dtsis include it in the range... > > Not that it matters much, mapping granularity is PAGE_SIZE anyway... > > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux- > m68k.org > > In personal conversations with technical people, I call myself a hacker. But > when > I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds [https://www2.renesas.eu/media/email/unicef_2017.jpg] This Christmas, instead of sending out cards, Renesas Electronics Europe have decided to support Unicef with a donation. For further details click here<https://www.unicef.org/> to find out about the valuable work they do, helping children all over the world. We would like to take this opportunity to wish you a Merry Christmas and a prosperous New Year. Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, Buckinghamshire, SL8 5FH, UK. Registered in England & Wales under Registered No. 04586709.
