On Mon, Feb 19, 2018 at 06:49:50PM +0100, Geert Uytterhoeven wrote:
> Hi Simon,
> On Mon, Feb 19, 2018 at 6:47 PM, Simon Horman <ho...@verge.net.au> wrote:
> > On Tue, Feb 20, 2018 at 12:02:58AM +0800, kbuild test robot wrote:
> >> tree: https://git.kernel.org/pub/scm/linux/kernel/git/horms/renesas.git
> >> soc-for-v4.17
> >> head: 8b49a80541c565d5d8482f15350ab861f60455a1
> >> commit: 8b49a80541c565d5d8482f15350ab861f60455a1 [6/6] soc: renesas:
> >> rcar-sysc: add R8A77980 support
> >> config: i386-allmodconfig (attached as .config)
> >> compiler: gcc-7 (Debian 7.3.0-1) 7.3.0
> >> reproduce:
> >> git checkout 8b49a80541c565d5d8482f15350ab861f60455a1
> >> # save the attached .config to linux build tree
> >> make ARCH=i386
> >> All errors (new ones prefixed by >>):
> >> >> drivers/soc/renesas/r8a77980-sysc.c:12:10: fatal error:
> >> >> dt-bindings/power/r8a77980-sysc.h: No such file or directory
> >> #include <dt-bindings/power/r8a77980-sysc.h>
> >> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> >> compilation terminated.
> >> vim +12 drivers/soc/renesas/r8a77980-sysc.c
> >> 11
> >> > 12 #include <dt-bindings/power/r8a77980-sysc.h>
> >> 13
> > Ooops. I missed that
> > 8b49a80541c5 ("soc: renesas: rcar-sysc: add R8A77980 support")
> > depends on
> > eaf8509d3d97 ("dt-bindings: power: add R8A77980 SYSC power domain
> > definitions")
> > Perhaps I should just squash the latter into the former.
> > Sergei, Geert, any thoughts?
> Just queue them up in the same branch, like you did before for other SoCs?
Sure, that seems like the simplest approach.
I'll make it so.