Hi Kaneko-san,

On Sun, Mar 11, 2018 at 9:26 PM, Yoshihiro Kaneko <ykaneko0...@gmail.com> wrote:
> Signed-off-by: Yoshihiro Kaneko <ykaneko0...@gmail.com>

Thanks for your patch!

> --- a/arch/arm64/boot/dts/renesas/r8a77995.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r8a77995.dtsi
> @@ -402,5 +402,36 @@
>                         #phy-cells = <0>;
>                         status = "disabled";
>                 };
> +
> +               thermal: thermal@e61f0000 {

According to the Hard User Manual rev. 0.80, the base address is e6190000?

> +                       compatible = "renesas,thermal-r8a77995",
> +                                    "renesas,rcar-thermal";

I would drop the fallback property, cfr. my comments on the DT binding
patch.

> +                       reg = <0 0xe61f0000 0 0x10>, <0 0xe61f0100 0 0x38>;

0xe619... (twice)

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Reply via email to