Hi Simon-san,
> From: Simon Horman, Sent: Friday, April 20, 2018 6:55 PM
>
> Hi Shimoda-san,
>
> On Wed, Apr 11, 2018 at 06:37:41PM +0900, Yoshihiro Shimoda wrote:
> > This patch adds basic support for the Renesas R-Car E3 (R8A77990) SoC:
> > - PSCI
> > - CPU (single)
> > - Cache controller
> > - Main clocks and controller
> > - Interrupt controller
> > - Timer
> > - PMU
> > - Reset controller
> > - Product register
> > - System controller
> > - UART for console
> >
> > Inspried by a patch by Takeshi Kihara in the BSP.
> >
> > Signed-off-by: Yoshihiro Shimoda <[email protected]>
>
> Thanks for your patch. I'd like to request a few minor updates
> as per my comments below.
Thank you for the review!
> > ---
> > arch/arm64/boot/dts/renesas/r8a77990.dtsi | 131
> > ++++++++++++++++++++++++++++++
> > 1 file changed, 131 insertions(+)
> > create mode 100644 arch/arm64/boot/dts/renesas/r8a77990.dtsi
> >
> > diff --git a/arch/arm64/boot/dts/renesas/r8a77990.dtsi
> > b/arch/arm64/boot/dts/renesas/r8a77990.dtsi
> > new file mode 100644
> > index 0000000..310bfd9
> > --- /dev/null
> > +++ b/arch/arm64/boot/dts/renesas/r8a77990.dtsi
> > @@ -0,0 +1,131 @@
> > +/* SPDX-License-Identifier: GPL-2.0 */
> > +/*
> > + * Device Tree Source for the r8a77990 SoC
> > + *
> > + * Copyright (C) 2018 Renesas Electronics Corp.
> > + */
> > +
> > +#include <dt-bindings/clock/renesas-cpg-mssr.h>
> > +#include <dt-bindings/interrupt-controller/arm-gic.h>
> > +
> > +/ {
> > + compatible = "renesas,r8a77990";
> > + #address-cells = <2>;
> > + #size-cells = <2>;
> > +
> > + cpus {
> > + #address-cells = <1>;
> > + #size-cells = <0>;
> > +
> > + /* 1 core only at this point */
> > + a53_0: cpu@0 {
> > + compatible = "arm,cortex-a53", "arm,armv8";
> > + reg = <0x0>;
> > + device_type = "cpu";
> > + power-domains = <&sysc 5>;
> > + next-level-cache = <&L2_CA53>;
> > + enable-method = "psci";
> > + };
> > +
> > + L2_CA53: cache-controller@0 {
> > + compatible = "cache";
> > + reg = <0>;
> > + power-domains = <&sysc 21>;
> > + cache-unified;
> > + cache-level = <2>;
> > + };
> > + };
> > +
> > + extal_clk: extal {
> > + compatible = "fixed-clock";
> > + #clock-cells = <0>;
> > + /* This value must be overridden by the board */
> > + clock-frequency = <0>;
> > + };
> > +
> > + psci {
> > + compatible = "arm,psci-0.2";
> > + method = "smc";
> > + };
> > +
> > + soc: soc {
> > + compatible = "simple-bus";
> > + interrupt-parent = <&gic>;
> > + #address-cells = <2>;
> > + #size-cells = <2>;
> > + ranges;
> > +
> > + gic: interrupt-controller@f1010000 {
> > + compatible = "arm,gic-400";
> > + #interrupt-cells = <3>;
> > + #address-cells = <0>;
> > + interrupt-controller;
> > + reg = <0x0 0xf1010000 0 0x1000>,
> > + <0x0 0xf1020000 0 0x20000>,
> > + <0x0 0xf1040000 0 0x20000>,
> > + <0x0 0xf1060000 0 0x20000>;
> > + interrupts = <GIC_PPI 9
> > + (GIC_CPU_MASK_SIMPLE(1) |
> > IRQ_TYPE_LEVEL_HIGH)>;
> > + clocks = <&cpg CPG_MOD 408>;
> > + clock-names = "clk";
> > + power-domains = <&sysc 32>;
> > + resets = <&cpg 408>;
> > + };
>
> Please sort sub-nodes of the soc node by:
> 1. Primary key: base address
> 2. Secondary key: IP block
>
> You can use arch/arm64/boot/dts/renesas/r8a7795.dtsi as a guide.
Oops, I assumed that all nodes are sorted by alphabet order...
I'll fix this in v2.
> > +
> > + timer {
> > + compatible = "arm,armv8-timer";
> > + interrupts = <GIC_PPI 13
> > + (GIC_CPU_MASK_SIMPLE(1) |
> > IRQ_TYPE_LEVEL_LOW)>,
> > + <GIC_PPI 14
> > + (GIC_CPU_MASK_SIMPLE(1) |
> > IRQ_TYPE_LEVEL_LOW)>,
> > + <GIC_PPI 11
> > + (GIC_CPU_MASK_SIMPLE(1) |
> > IRQ_TYPE_LEVEL_LOW)>,
> > + <GIC_PPI 10
> > + (GIC_CPU_MASK_SIMPLE(1) |
> > IRQ_TYPE_LEVEL_LOW)>;
> > + };
> > +
> > + pmu_a53 {
> > + compatible = "arm,cortex-a53-pmu";
> > + interrupts = <GIC_SPI 84 IRQ_TYPE_LEVEL_HIGH>;
> > + interrupt-affinity = <&a53_0>;
> > + };
>
> The timer and pmu_a53 nodes do not have a base address and are thus
> not on the bus. Please move them outside of the SoC node.
I got it. I will fix it in v2.
Best regards,
Yoshihiro Shimoda
